Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include hvc1 codec to load h.265 videos #965

Merged
merged 1 commit into from
Dec 14, 2024
+1 −1
Merged

feat: include hvc1 codec to load h.265 videos #965

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion screenpipe-app-tauri/components/video.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ export const VideoComponent = memo(function VideoComponent({
</div>
) : (
<video controls className="w-full rounded-md">
<source src={mediaSrc} type="video/mp4" />
<source src={mediaSrc} type="video/mp4; codecs=hvc1" />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried a bunch of different things. video-js, flv-h265.js, but after a few hours of research and trying and error, I learned webkit (the browser thing Mac uses) has native support to h.265 through hvc1 codec.

Your browser does not support the video tag.
</video>
)}
Expand Down
Loading