feat: add DID Auth in JWT #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youngjoon-lee
requested review from
gyuguen,
audtlr24,
0xHansLee,
inchori and
tjyoon0324
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented the W3C DID Authentication using JWT, as described in https://www.w3.org/Security/201812-Auth-ID/04_-_Day_1_-_Understanding_DID_Auth.pdf.
The spec also says that we can use Verifiable Presentation for DID Auth, as @H4NLee did in medibloc/vc-sdk#20.
But unfortunately, the well-known VC library in JS is not compatible with our Panacea DID Document (defined in protobuf). I think it's not simple to make it work. So, let's go with JWT for now, and make VP works later.
(It means that vc-sdk should support DID Auth in JWT as well: medibloc/vc-sdk#21).