Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implementation of DID authentication #20

Merged
merged 3 commits into from
Mar 8, 2023
Merged

feat: implementation of DID authentication #20

merged 3 commits into from
Mar 8, 2023

Conversation

0xHansLee
Copy link
Contributor

For DID authentication, an empty presentation with proof is used (ref).
User can verify the DID auth by using the VerifyPresentation.

@0xHansLee 0xHansLee self-assigned this Mar 3, 2023
youngjoon-lee
youngjoon-lee reviewed Mar 6, 2023
View reviewed changes
pkg/vc/command_test.go Outdated Show resolved Hide resolved
pkg/vdr/did_auth_test.go Show resolved Hide resolved
@0xHansLee 0xHansLee mentioned this pull request Mar 6, 2023
Open
youngjoon-lee
youngjoon-lee approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@youngjoon-lee youngjoon-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

audtlr24
audtlr24 approved these changes Mar 7, 2023
View reviewed changes
Copy link

@audtlr24 audtlr24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

gyuguen
gyuguen approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@gyuguen gyuguen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

inchori
inchori approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@inchori inchori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@0xHansLee 0xHansLee merged commit 255994f into main Mar 8, 2023
@0xHansLee 0xHansLee deleted the han/did-auth branch March 8, 2023 02:07
This was referenced Mar 8, 2023
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youngjoon-lee youngjoon-lee youngjoon-lee approved these changes

@gyuguen gyuguen gyuguen approved these changes

@audtlr24 audtlr24 audtlr24 approved these changes

@inchori inchori inchori approved these changes

Assignees

@0xHansLee 0xHansLee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@0xHansLee @youngjoon-lee @gyuguen @audtlr24 @inchori