type fixes and some bugfixes #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
right now they are only present in LayerStats BUT ONLY if returned from getStats(), not getActiveLayers(). a similar thing happens with EncodingStats. this PR makes them always present.
(it's already checked for us in getMediaStats)
we do a dangerous pattern where we assume the type of this.depacketizer depending on if it's present or not. indicate this to the type checker.
the type system has some difficulty following Symbol accesses
murillo128
requested changes
May 28, 2024
murillo128
reviewed
May 28, 2024
This reverts commit 3087d20.
murillo128
reviewed
May 28, 2024
|
only a few type annotations changed since last review, so I'll merge this in now |
mildsunrise
added a commit
to medooze/video-codecs-node
that referenced
this pull request
Jun 19, 2024
see medooze/media-server-node#261 and the fixups in master afterwards
mildsunrise
added a commit
to medooze/audio-codecs-node
that referenced
this pull request
Jun 19, 2024
see medooze/media-server-node#261 and the fixups in master afterwards
mildsunrise
added a commit
to medooze/rtmp-server-node
that referenced
this pull request
Jun 19, 2024
see medooze/media-server-node#261 and the fixups in master afterwards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
most of this is just fixing type errors (I'd like to start enforcing typechecking in CI, since it would have caught bugs such as this one)
but there's also a couple bugfixes.
I suggest reviewing commit by commit.