Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type fixes and some bugfixes #261

Merged
merged 27 commits into from
Jun 3, 2024
Merged
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
60b43c1
cleanup imports
mildsunrise May 27, 2024
699a708
cleanup old code that isn't used
mildsunrise May 27, 2024
ce8d08b
some fields are optional and they shouldn't
mildsunrise May 27, 2024
d48261c
deduplicate code
mildsunrise May 27, 2024
7d4efcb
make presence of totalBytes + numPackets consistent
mildsunrise May 27, 2024
1cd687c
fix type errors for mediaStats.field > 0
mildsunrise May 27, 2024
ce32452
silence type errors for depacketizer
mildsunrise May 27, 2024
7433637
bug in 700620dd3
mildsunrise May 27, 2024
c7ffabb
another bugfix
mildsunrise May 27, 2024
283ff4c
some type fixes in other files
mildsunrise May 27, 2024
3ad4752
some validation
mildsunrise May 27, 2024
3087d20
add utils.mapGet
mildsunrise May 27, 2024
395bc94
add SharedPointer.getPointer()
mildsunrise May 27, 2024
1a08703
fixup: if (ssrc) check
mildsunrise May 28, 2024
4a3de62
fixup! Transport#publish()
mildsunrise May 28, 2024
3666169
Revert "add utils.mapGet"
mildsunrise May 28, 2024
69c333b
replace mapGet with ?.
mildsunrise May 28, 2024
4753405
make IncomingStream#transport and receiver optional
mildsunrise May 28, 2024
645bca8
fixup: Transport#addRemoteCandidate: return false instead of throw
mildsunrise May 28, 2024
b0be0ce
some more annotations
mildsunrise May 28, 2024
db76052
instead of commenting out, add @ts-expect-error
mildsunrise May 28, 2024
06c436b
fix error when rtx / fec ssrc is not specified
mildsunrise May 28, 2024
3a9d1ff
use SemanticSDP's TrackType where possible
mildsunrise May 29, 2024
37ef482
fixup: preserve track ids when publishing
mildsunrise May 29, 2024
6511f8c
couple more annotations in old files
mildsunrise May 29, 2024
9101d57
one more
mildsunrise May 29, 2024
fbfc6f2
bring types for lfsr
mildsunrise Jun 3, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/Transport.js
Original file line number Diff line number Diff line change
Expand Up @@ -561,8 +561,10 @@ class Transport extends Emitter
if ("relay"===candidate.getType())
{
//Get relay ip and port
ip = candidate.getRelAddr();
port = candidate.getRelPort();
const [relIp, relPort] = [candidate.getRelAddr(), candidate.getRelPort()];
mildsunrise marked this conversation as resolved.
Show resolved Hide resolved
if (!relIp || !relPort)
throw new Error("relay candidate is lacking relay IP or port");
mildsunrise marked this conversation as resolved.
Show resolved Hide resolved
[ip, port] = [relIp, relPort];
} else {
//Get ip and port
ip = candidate.getAddress();
Expand Down