Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: for alot of OTC's to not display health properly in circle bars. #463

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

themaoci
Copy link
Contributor

@themaoci themaoci commented Mar 9, 2023

Description

Fix for alot of OTC's to not display health properly in circle bars.
If your server doesn't have this properly implemented,
it will cause alot of unnecessary deaths from players which will be unfair.
My friend reported me that while he was using his otcv8 and asked for a fix so here you go :)

Behaviour

Actual

Game is randomly not update health on circle bars and then you will simply die :)

Expected

Game updating this value preety much live should be expected

Fixes

# (issue)

Type of change

Please delete options that are not relevant.

  • [X ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [ X] Test by running multiple bots on random tibia servers via my friend(he used otcv8 but mechanic and functions are pretty much the same), showing me that if script is using getHealthPercent() it will lag with using healing spells which will result in death of character.

Test Configuration:

  • Server Version: any from 8.6 and above (mostly TFS'es but can also happend on other
  • Client: OTC mehah, OTCv8, OTC edubart
  • Operating System: All

Checklist

  • [X ] My code follows the style guidelines of this project
  • [X ] I have performed a self-review of my own code
  • [X ] I checked the PR checks reports
  • [ X] I have commented my code, particularly in hard-to-understand areas
  • [X ] I have made corresponding changes to the documentation
  • [X ] My changes generate no new warnings
  • [X ] I have added tests that prove my fix is effective or that my feature works

@mehah mehah merged commit 95b6ecd into mehah:main Mar 10, 2023
@mehah mehah changed the title Fix for alot of OTC's to not display health properly in circle bars. fix: for alot of OTC's to not display health properly in circle bars. Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants