-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Target ruby 3 with rubocop #370
Target ruby 3 with rubocop #370
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #370 +/- ##
=======================================
Coverage 88.90% 88.90%
=======================================
Files 13 13
Lines 757 757
=======================================
Hits 673 673
Misses 84 84 ☔ View full report in Codecov by Sentry. |
@ellnix sorry can you fix the git conflicts? 🙈 |
This seems to have been missed when updating requirements from ruby 2.6 to 3.
f26a8c9
to
451f931
Compare
Apologies for ghosting for so long, fixed the conflict (it was an edit to a file that has since been deleted) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors merge
Build succeeded: |
Rubocop's config was still enforcing ruby 2 code style. This is just a step that was missing in #367.