Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target ruby 3 with rubocop #370

Merged
merged 1 commit into from
Sep 15, 2024

Conversation

ellnix
Copy link
Collaborator

@ellnix ellnix commented Jul 23, 2024

Rubocop's config was still enforcing ruby 2 code style. This is just a step that was missing in #367.

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.90%. Comparing base (c4abc60) to head (451f931).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #370   +/-   ##
=======================================
  Coverage   88.90%   88.90%           
=======================================
  Files          13       13           
  Lines         757      757           
=======================================
  Hits          673      673           
  Misses         84       84           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

brunoocasali
brunoocasali previously approved these changes Aug 7, 2024
@curquiza
Copy link
Member

curquiza commented Aug 7, 2024

@ellnix sorry can you fix the git conflicts? 🙈

@curquiza curquiza added the maintenance Anything related to maintenance (CI, tests, refactoring...) label Aug 7, 2024
This seems to have been missed when updating requirements from ruby 2.6
to 3.
@ellnix
Copy link
Collaborator Author

ellnix commented Sep 13, 2024

@ellnix sorry can you fix the git conflicts? 🙈

Apologies for ghosting for so long, fixed the conflict (it was an edit to a file that has since been deleted)

Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@meili-bors meili-bors bot merged commit b67b98d into meilisearch:main Sep 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Anything related to maintenance (CI, tests, refactoring...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants