Fix(serializer): Properly normalize DateTimeInterface objects
#309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI, I could not run PHPUnit on my side - waiting for #308 to be merged |
norkunas
reviewed
Dec 13, 2023
bpolaszek
force-pushed
the
fix/date-normalization
branch
from
d091e62 to
0985eb3
Compare
norkunas
previously approved these changes
Dec 13, 2023
bpolaszek
force-pushed
the
fix/date-normalization
branch
from
0985eb3 to
314be39
Compare
|
Not sure how we should tackle compat with 5.4 |
I think the |
norkunas
force-pushed
the
fix/date-normalization
branch
from
62f7141 to
845efd5
Compare
norkunas
approved these changes
Dec 14, 2023
|
bors merge |
meili-bors bot
added a commit
that referenced
this pull request
Dec 14, 2023
309: Fix(serializer): Properly normalize `DateTimeInterface` objects r=norkunas a=bpolaszek # Pull Request ## Related issue Fixes #304 ## What does this PR do? - `DateTimeInterface` objects are now normalized as unix timestamps integers, in the context of a serialization initiated by this bundle. ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: Beno!t POLASZEK <bpolaszek@gmail.com>
|
bors ping |
|
pong |
|
Timed out. |
|
bors try |
tryTimed out. |
|
bors try |
tryTimed out. |
|
Thank you @bpolaszek |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #304
What does this PR do?
DateTimeInterfaceobjects are now normalized as unix timestamps integers, in the context of a serialization initiated by this bundle.PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!