Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore Face node #8

Merged
merged 12 commits into from
Jul 5, 2023
Merged

Restore Face node #8

merged 12 commits into from
Jul 5, 2023

Conversation

melMass
Copy link
Owner

@melMass melMass commented Jul 2, 2023

What changes are in this PR

  • fix: all opened issues
    • better log, use the env var MTB_DEBUG=true to enable more debugging like before.
    • separate faceswaper inference and model loader.
  • feat: RestoreFace + LoadFaceSwapModel nodes (using GFPGAN that was added as a submodule)

The intermediate steps are saved in Comfy's temp dir (if enabled on the node):
image
cropped_faces_compare_001_00001_

Todo

  • Test in isolation
  • TODOs added in code

@melMass melMass linked an issue Jul 2, 2023 that may be closed by this pull request
@melMass melMass changed the title various small fixes Restore Face node Jul 3, 2023
melMass added 7 commits July 4, 2023 00:38
this hooks into comfy's core upscaler model loader.
It seems to work, as in it doesn't fail but it's not producing the
proper results.
I was just not returning from tensor2np 🦀☠️
this PR is mostly done
tested in python-embed mode too
@melMass melMass merged commit 7585624 into main Jul 5, 2023
@melMass melMass deleted the dev/small-fixes branch July 5, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strange log data
1 participant