Skip to content

Commit

Permalink
chore(build): Encode all files consistently as UTF-8 and add linter r…
Browse files Browse the repository at this point in the history
…ule to enforce it.

BOM markers were breaking chrome unpacked extension loading because webpack never adds BOM markers by default.

Fixes #455
TESTED=Built and packaged in chrome with no problems.
  • Loading branch information
melink14 committed May 6, 2021
1 parent fe81afc commit f393ee0
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
"sort-imports-es6-autofix/sort-imports-es6": "error",
"node/no-unpublished-import": "off",
"@typescript-eslint/no-var-requires": "off",
"unicode-bom": "error",
// TODO(espeed): Remove these and fix errors.
"no-undef": "off",
"prefer-arrow-callback": "off",
Expand Down
2 changes: 1 addition & 1 deletion extension/data.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/*
/*
Rikaikun
Copyright (C) 2010 Erek Speed
Expand Down
2 changes: 1 addition & 1 deletion extension/rikaichan.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/*
/*
Rikaikun
Copyright (C) 2010 Erek Speed
Expand Down

0 comments on commit f393ee0

Please sign in to comment.