-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-line comments breaking chrome unpacked extension loading #455
Comments
Probably caused by a BOM character being before the start of the file but after the webpack_exports. But Sam said removing multiline comments fixed it for him... |
It looks like I can fix it by adding |
It seems that it's also caused by the ts files being saved as UTF-8 with BOM in vscode which gets treated weirdly after compilation. For some reason only data.ts and rikaichan.ts have this encoding so only they cause the problem. Probably better to just resave the files without the encoding but I wonder if that will show up in version control |
There's a eslint rule for encoding which I'll turn on to ensure no BOM problems. Editor config has it but vscode doesn't support it yet. If we wanted bom files then the html |
…ule to enforce it. BOM markers were breaking chrome unpacked extension loading because webpack never adds BOM markers by default. Fixes #455 TESTED=Built and packaged in chrome with no problems.
🎉 This issue has been resolved in version 1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Reported here #363 (reply in thread) and confirmed by me recently.
Uncaught SyntaxError: Invalid or unexpected token
data.js:2 (無名関数)
The text was updated successfully, but these errors were encountered: