Welcome to rikaikun Discussions!

[melink14]

👋 Welcome!

We’re using Discussions as a place to connect with other members of our community. We hope that you:

• Ask questions you’re wondering about.
• Share ideas.
• Engage with other community members.
• Welcome others and are open-minded. Remember that this is a community we
  build together 💪.

To get started, comment below with an introduction of yourself and tell us about what you do with this community.

[1tomadeira]

Hello, hope you're doing fine.

I had the extension working completly fine, yet for some reason it ended all being all white (happened me once already one year ago, no more), and tried to reinstall the extension again. Unfortunely I noticed it was removed from Opera Store. Yes there is an option to use Chrome Extensions, but many use the Opera to avoid using Google stuff.

I understand your decision, but will the Opera version be discontinued?

Best Regards.

[melink14]

Hi!

Sorry to hear about the extension being removed from the Opera store. I actually had nothing to do with it being uploaded there and I'm not sure who did it or why they chose to remove it later.

That being said, it seems like it's pretty common to install extensions meant for Google Chrome on Opera. I sympathize with wanting to avoid Google stuff but in this case you can consider chrome extensions not Google stuff but community stuff that happens to work on Google software!

[SamDunlap]

Hello! I really enjoy using this extension to assist with some of my school work if it contains kanji I have not learned.

For a school project I am required to create and submit a bug fix for an open source project, and I would love to help out this project, as it has been so useful to me over my college career.

I see that some of the issues are tagged with "good first issue" already and I am curious if this is a good place to start.

Thanks!

[SamDunlap]

TLDR; I fixed it by removing all multiline comments, I will certainly revert this change for any PR's made, but multiline comments were seen as an unknown token by Chrome for some reason.

[melink14]

(You can keep discussing here or make your own topic(s) in the dicussion group if you want)

I hadn't seen this; I wonder if it's something that's only happening with newer versions of chrome (since it's been awhile since I've tested loading unpacked after building...)

Can you open a bug with a pointer with the full details you found? No worries if not, I'll also try to remember to check later!

[SamDunlap]

Yeah I can take care of that at some point today. I had the same issue with both Chrome and chromium based Edge. If I run into anything else I'll just start a new discussion topic.

[SamDunlap]

I have fixed the issue linked here #346. I don't seem to have the ability to create a branch related to the issue. How should I proceed?

[melink14]

(FYI, I filed the issue about synatx errors with comments here: #455; it seems to be an encoding problem so not sure why removing comments fixed it. :D)

[melink14]

Thanks! This might be a failing in the docs but maybe you didn't create a fork first? That's generally the first step, then you can open a pull request with your change. I'm thinking my contribution docs may need a few edits! 2021年4月22日(木) 11:51 Samuel Dunlap ***@***.***>:

…

I have fixed the issue linked here #346 <#346>. I don't seem to have the ability to create a branch related to the issue. How should I proceed? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#363 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAI7HZUTCSLHU7AP6YDJRV3TJ6FMLANCNFSM4VYXCCKQ> .

[SamDunlap]

Yeah I don't seem to have the ability to do that either. I created a branch locally, but I cannot push that, nor can I create one on the web interface.

[melink14]

Looking at your account it seems like you haven't forked it yet so I should be a bit more explicit.

By fork, I mean the github notion of forking which creates a copy of the repository in your account. (For example, a past contributor: https://github.com/darren-lester/rikaikun)

There's a button to fork in the top right of the main repo page but you can see a guide here:
https://app.egghead.io/lessons/javascript-how-to-fork-and-clone-a-github-repository?pl=how-to-contribute-to-an-open-source-project-on-github

(The other sections might be useful as well)

You can't make a branch directly due to permission issues but you can treat a fork as one huge branch owned by you. :)

[SamDunlap]

Thanks for all the help! I think I finally got it squared away. I haven't used GitHub as much as I probably should have in my college career, but I suppose this is good practice. I'm assuming you will let me know if you would like any of my changes edited in the PR itself.

[melink14]

It's no problem; it's never to early to start! See you over in the PR!

[SamDunlap]

I was looking to fix this bug too, I have run into this bug myself, but I can't seem to find the detection logic. Can you point me in the right direction?

Issue: #215

--I actually just copied the div from the issue into an html file and rikaikun detected it.
--I also can't replicate on Twitch.tv, so it must be resolved?

[SamDunlap]

I'm still curious about where the detection logic is though, so I can fix the issue with google docs as well.

Issue: #213

[melink14]

Detection code starts here:

rikaikun/extension/rikaicontent.ts

Line 914 in a2cd8c1

tryUpdatePopup: function (ev) {

Basically, whenever the mouse moves this function is called and it tries to see if there's text to look up at that point.

I will be honest, the detection code is some of the hardest code to work with since I've not refactored it in many years and it has many edge cases to handle bugs. Plus since there are no tests for rikaikun, you have to constantly worry that you broke a rare edge case when making changes.

Ideally, I hope to re-write it with modern practices so it's easier to maintain and edit but just know that now it might end up being harder than you think and it might require more discussion in the PR.

I'd start with putting break points in various places and seeing the code flow in the broken case. Also, we should try to figure out what makes the broken HTML not work in general and see if we can fix it in the most general way possible; we don't want a solution that only works for google docs if we can help it.

[SamDunlap]

For sure, I will definitely take a look. I'll submit a PR early so I am on track.

[Zkarts]

Hey, I got the built extension to run with the info above, which was great, but I wasn't able to figure out where to look for my issue. Heck, I don't even know if it would be possible.
Basically, I have a Japanese epub that I want to try reading through an epub reader extension with the help of rikaikun. That leads to a url in the form of chrome-extension://jhhclmfgfllimlhabjkgkeebkbiadflb/reader.html?filename=file. I managed to figure out rikaikun apparently doesn't have access to the page as it says "cannot read or write site data" or something like that when I right-click the rikaikun icon. I'm not sure if it would be possible to grant rikaikun access to that page/URL, but I also don't really know where to look as I've never worked on chrome extensions before.

[melink14]

Hi!

This has come up before and I filed an issue here: #381 which you can follow and collaborate on. IIRC, there were some old posts saying it was possible but nothing verified recently!

In the meantime, also consider this web only e-book reader some bloggers have liked:
https://ttu-ebook.web.app/

[Zkarts]

Thanks for chasing this down. I thought I saw some similar issues that said this was fixed, so I got confused when I didn't get it to work.
Maybe it does make sense for them not to allow it based on extensions stealing other extensions' permissions that way, but cool to see you filed a report for it :)

Until then the web-based e-book reader sounds like a great solution to hold me over!
Only now that I try it, the text is oriented vertically and that flips rikaikun's text sideways as well 😅

[melink14]

Haha, that's amazing. I had bookmarked the site but hadn't tested it yet. 😂

That being said something like this would be prevented by #221 but I think a faster fix would be to set writing-mode: horizontal-tb on the #rikaichan-window styles. (You could do that yourself via devtools in the super short term!)

Filed #613 for the eaiser fix!

[Zkarts]

I can confirm it works! The only thing I ran into was that the popup would cover most of the text that it was translating, so locally I added a margin-left of 2em to offset it a bit. It doesn't look too awful for horizontal text per se either, but it's not directly underneath the cursor anymore then. The best option I think would be to recognise the vertical writing of the base text and adding the offset depending on that.

[melink14]

Yeah, good point on the positioning. The pop up position code is super ugly (handling edge cases around if the mouse is near a screen edge.) so I might wait on that one given how easy it is to change for those in the know.

[maawisul]

Hello.

I want to contribute to this repository as a part of my school project. I am introduced to this extension just recently and have not used it that much yet but felt that this extension will help me greatly in the future with my Japanese language study.

I have taken a look at issue 898 and 89 and have several questions about them.

For issue 89, can the fix be done on the dictionary or it must strictly be done on the code as I felt like the underlying issue was a missing entry from the dictionary.

Secondly, on issue 898, the extension installed from chrome webstore worked fine for me on a document in Google Docs, however when I load the unpacked version into chrome, it didn't seem to work anymore.

Should I reply on each respective issues to figure out my next step? I am eager to help fix these issues as soon as possible.
Thanks!

[melink14]

HI @maawisul!

Thanks for your interest! Those are good questions but to your last point, I think it would be best if you added them to the issues directly so that discussion for each issue all happens in one place!

If you want, you can just copy your question to each issue and I'll answer them there!

[maawisul]

Noted. Looking forward to the discussions