FR: Explicilty set rikaikun to horizontal writing mode to avoid inheriting veritcal text styles from host page #613
Assignees
Labels
Comments
|
(Maybe change positioning to be right of vertical text as well. |
|
Just realized I need to do this in each theme's CSS so I might try to combine them into one first. (#222) |
melink14
added a commit
that referenced
this issue
Jul 20, 2021
Avoids inheriting veritcal text styles from host page when they're overly broad. Long term, shadow dom should help, and we should also make a popup position that works well for vertical text. Fixes #613
This was referenced Jul 20, 2021
melink14
added a commit
that referenced
this issue
Jul 20, 2021
Avoids inheriting veritcal text styles from host page when they're overly broad. Long term, shadow dom should help, and we should also make a popup position that works well for vertical text. Fixes #613
melink14
pushed a commit
that referenced
this issue
Jul 20, 2021
## [2.1.0](v2.0.1...v2.1.0) (2021-07-20) ### Features * **css:** Move popup themes into a single file using CSS variables ([#623](#623)) ([75241b5](75241b5)), closes [#222](#222) * **popup:** Explicilty sets rikaikun to horizontal writing mode ([#624](#624)) ([5fae815](5fae815)), closes [#613](#613) * Set `offline_enabled` to true in extension manifest ([#612](#612)) ([202aeac](202aeac)), closes [#429](#429) ### Bug Fixes * **dict:** Update dictionaries to latest versions. ([#620](#620)) ([9a67cb1](9a67cb1))
|
🎉 This issue has been resolved in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See discussion here: #363 (reply in thread)
Can repro at online ebook reader: https://ttu-ebook.web.app/
Possible solution:
writing-mode: horizontal-tb;on#rikaichan-windowThis is an easier pre-fix before migrating to shadow dom for the popup: #221
The text was updated successfully, but these errors were encountered: