feat(css): Move popup themes into a single file using CSS variables #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #623 +/- ##
==========================================
+ Coverage 38.89% 41.62% +2.73%
==========================================
Files 7 7
Lines 2900 2897 -3
Branches 46 53 +7
==========================================
+ Hits 1128 1206 +78
+ Misses 1772 1691 -81
Continue to review full report at Codecov.
|
The process exposed some minor consistency issues so this refactor has minor user visible changes. Fixes #222
melink14
force-pushed
the
melink14/issue222/Refactor-CSS-to-avoid-duplication
branch
from
24218df to
30a6488
Compare
melink14
pushed a commit
that referenced
this pull request
Jul 20, 2021
## [2.1.0](v2.0.1...v2.1.0) (2021-07-20) ### Features * **css:** Move popup themes into a single file using CSS variables ([#623](#623)) ([75241b5](75241b5)), closes [#222](#222) * **popup:** Explicilty sets rikaikun to horizontal writing mode ([#624](#624)) ([5fae815](5fae815)), closes [#613](#613) * Set `offline_enabled` to true in extension manifest ([#612](#612)) ([202aeac](202aeac)), closes [#429](#429) ### Bug Fixes * **dict:** Update dictionaries to latest versions. ([#620](#620)) ([9a67cb1](9a67cb1))
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The process exposed some minor consistency issues so this refactor has minor user visible changes.
Fixes #222