A minor commit to remove all warnings #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Melvic,
It seems that with this change all warnings that I got with
sbt assemblyfrom your latest state of the main branch inmelvic-ybanez/chiget resolved.Attaching related log file: chi_compilation_with_sbt_assembly_no_warnings_success.txt
Feel free to accept the PR if you agree with the change :).
Thanks !
PS: apologies for the silly commits, but I did that change (58b379c) originally before your many commits that bumped
chifromv3.0tov5.0, and I had to resolve the conflicts manually...