Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow snake case convention in folder vectordb #734

Closed
taranjeet opened this issue Sep 30, 2023 · 5 comments · Fixed by #1469
Closed

Follow snake case convention in folder vectordb #734

taranjeet opened this issue Sep 30, 2023 · 5 comments · Fixed by #1469
Labels
easy Easy difficulty good first issue Good for newcomers hacktoberfest

Comments

@taranjeet
Copy link
Member

🐛 Describe the bug

Located at embedchain/config/vectordb

It should be vector_db.

This task will involve changing the relevant imports everywhere and making sure that tests pass and nothing breaks.
@taranjeet taranjeet added good first issue Good for newcomers easy Easy difficulty hacktoberfest labels Sep 30, 2023
@Psudopodiya
Copy link

Psudopodiya commented Sep 30, 2023 •
edited
Loading

How do i test it out some way to run the code ?
Plus do you need it for only the folder name or for all the classes within (even tough the issue says "in the folder" , i feel like asking this)

@Prikshit7766
Copy link
Contributor

@Psudopodiya
Are you currently working on this task, or should I go ahead and start making the necessary changes?

@Psudopodiya
Copy link

Psudopodiya commented Sep 30, 2023 •
edited
Loading

@Prikshit7766
Sure go ahead with this one. Sorry do not have time for it right now

@Prikshit7766 Prikshit7766 mentioned this issue Sep 30, 2023
Closed
12 tasks
WebDevHarsha added a commit to WebDevHarsha/embedchain that referenced this issue Oct 1, 2023
@WebDevHarsha
FIX mem0ai#734 Changed vectordb into vector_db
f09ffc4
@WebDevHarsha WebDevHarsha mentioned this issue Oct 1, 2023
Closed
@shubham1234098
Copy link

hello can i contribute on it??

@PatelKeviin PatelKeviin mentioned this issue Nov 26, 2023
Closed
11 tasks
This was referenced Jul 7, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy Easy difficulty good first issue Good for newcomers hacktoberfest
Projects
None yet
Milestone
No milestone
5 participants
@taranjeet @Psudopodiya @Prikshit7766 @shubham1234098 and others