Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring vectordb naming convention in embedchain.config #1469

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Refactoring vectordb naming convention in embedchain.config #1469

merged 1 commit into from
Jul 8, 2024

Conversation

vatsalrathod16
Copy link
Contributor

Description

Renamed the vectordb with snakecase convention and refactored the code as required.

Fixes #734

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (does not change functionality, e.g. code style improvements, linting)
  • Documentation update

How Has This Been Tested?

Tested with Google embedder and LLM

import os
import requests
from bs4 import BeautifulSoup
from embedchain import App

app = App.from_config(config_path="config.yaml")
app_link = "https://en.wikipedia.org/wiki/Kobbie_Mainoo"
app.add(app_link)

while True:
    question = input("Enter question: ")
    if question in ["q", "exit", "quit"]:
        break
    answer = app.query(question)
    print(answer)

Config.yaml

llm:
  provider: google
  config:
    model: gemini-pro
    max_tokens: 1000
    temperature: 0.5
    top_p: 1
    stream: false

embedder:
  provider: google
  config:
    model: 'models/embedding-001'
    task_type: "retrieval_document"
    title: "Embeddings for Embedchain"
  • Unit Test
  • Test Script (please provide)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Made sure Checks passed

@deshraj deshraj merged commit 83e8c97 into mem0ai:main Jul 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Follow snake case convention in folder vectordb
2 participants