Add dynamic overlay update #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WojciechBarczynski
force-pushed
the
@WojciechBarczynski/add_dynamical_overlay_update
branch
from
c96ea72 to
0c5166a
Compare
WojciechBarczynski
force-pushed
the
@WojciechBarczynski/add_dynamical_overlay_update
branch
from
a6a3029 to
46f17ca
Compare
WojciechBarczynski
force-pushed
the
@WojciechBarczynski/add_dynamical_overlay_update
branch
from
2c8fbc2 to
5e62e22
Compare
varsill
reviewed
Jul 23, 2024
lib/update_overlay.ex
Outdated
Comment on lines
13
to
16
| overlay: Path.t() | Vix.Vips.Image.t(), | ||
| x: integer() | :center | :left | :right, | ||
| y: integer() | :middle | :top | :bottom, | ||
| blend_mode: Image.BlendMode.t() |
There was a problem hiding this comment.
I believe we could unify the typespecs for the filter options and for the update overlay struct.
… initial overlay and dynamic overlay changess
Add overlay description struct and use it in unified way for both the initial overlay and dynamic overlay changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability to dynamically update overlay