Streamlining and enhancing diagram rendering across various diagram types #5604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* develop: (462 commits) Update packages/mermaid/src/diagrams/sequence/parser/sequenceDiagram.jison fix: Simplify actor type of activeStart and activeEnd chore(deps): update all patch dependencies chore: Fix typo chore(deps): update all patch dependencies chore: remove repetitive words Update stateDiagram.md Update stateDiagram.md fix: simply from and to in message to string type docs: Add quadrant point styling feat: Change precedence of styling chore(deps): update all minor dependencies chore(deps): update all patch dependencies fix: eslint ignore, type definition chore(deps): update all patch dependencies fix: Remove `ImperativeState` type restriction. 📝🐛 fix schema link update latest news section Changes to rendering/gitGraph.spec.js - Added additional rendering test functionality for recognizing 'switch' as an alias to 'checkout'. 1. Changes to gitGraph.jison - Updated the regex to allow either 'checkout' or 'switch' 2. Changes to gitGraphParser.spec.js - Additional test coverage added for the changes made to the parser. 3. Changes to gitGraphParserV2.spec.js - Additional test coverafe added for the changes made to the parser. 4. Changes to gitgraph.md - Updated documentation to let users know that checkout/switch can be used interchangeably. ...
…aid-js/mermaid into 5237-unified-layout-common-renderer
…anup * 5237-unified-layout-common-renderer: (36 commits) 5237 New default width for flowchart edges #5237 Fix for rough styling of regular states and dividers in state diagrams chore: Remove "sideEffects: false" Added test for divider alignment Remove logs chore: Fix eslint errors chore: eslint autofix chore: Cleanup tsconfig chore: Fix lint Apply suggestions from code review chore: Remove extra words from cspell chore: Log granular rebuild times fix: Message wrap fix: Message wrap chore: Use `??` instead of `||` chore: Organise imports chore: Remove unused variables chore: Remove cross-env from eslint chore: Cleanup rules chore: Fix eslint issues ...
…aid-js/mermaid into 5237-unified-layout-common-renderer
…aid-js/mermaid into 5237-unified-layout-common-renderer
…anup * 5237-unified-layout-common-renderer: #5237 Fix fir subgraphs with elk #5237 Fix for diamond intersections with ELK, tweak #5237 Fix for diamond intersections with ELK fix for note with a composite state #5237 Handling of subgraphs using elk #5237 Handling of subgraphs using elk Fix fro direction in layout data
sidharthv96
reviewed
Jul 7, 2024
|
|
||
| --- | ||
|
|
||
| ### elk.nodePlacement.strategy |
There was a problem hiding this comment.
@knsv @ashishjain0512 Shouldn't these configs be proper objects?
Otherwise it will be very confusing, as we already support some configs in nested fashion.
config:
elk:
mergeEdges: true
nodePlacement:
strategy: SIMPLEchore: 5237 Cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
There is noticeable duplication in functionality among different diagram types. Several graph-based diagrams share common features in rendering, but these are implemented separately in each diagram type.
This PR introduces a Unified Layout Engine: Implement a singular layout engine for all graph-based diagrams.
Benefits:
Resolves #5237
📏 Design Decisions
Describe the way your implementation works or what design decisions you made if applicable.
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.developbranch