chore: 5237 Cleanup #5606
Merged
chore: 5237 Cleanup #5606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Argos notifications ↗︎ Waiting for the first build to start… |
4 tasks
| @@ -54,7 +40,7 @@ export const draw = async function (text: string, id: string, _version: string, | |||
|
|
|||
| data4Layout.type = diag.type; | |||
| data4Layout.layoutAlgorithm = layout; | |||
| data4Layout.direction = DIR; | |||
| data4Layout.direction = getDirection(); | |||
There was a problem hiding this comment.
Even though this makes it good for clean code, sometimes it makes it hard to debug without the variable.
| * @param el | ||
| * @param data | ||
| */ | ||
| export function insertElementsForSize(el, data) { |
There was a problem hiding this comment.
Maybe leave this one until the big PR for v11 is ready for merge.
| @@ -538,16 +520,7 @@ export const insertEdge = function (elem, edge, clusterDb, diagramType, startNod | |||
| lineData.splice(-1, 0, midPoint); | |||
| } | |||
| // This is the accessor function we talked about above | |||
| let curve; | |||
There was a problem hiding this comment.
Leave these settings as is for future use and reference
| @@ -556,7 +529,6 @@ export const insertEdge = function (elem, edge, clusterDb, diagramType, startNod | |||
| } | |||
|
|
|||
| const { x, y } = getLineFunctionsWithOffset(edge); | |||
| // const lineFunction = edge.curve ? line().x(x).y(y).curve(curve) : roundedCornersLine; | |||
There was a problem hiding this comment.
Leave the lineFunction for now, we can remove it in the big PR.
Still working out some issue around it.
| @@ -592,11 +564,6 @@ export const insertEdge = function (elem, edge, clusterDb, diagramType, startNod | |||
| if (edge.look === 'handdrawn') { | |||
| const rc = rough.svg(elem); | |||
| Object.assign([], lineData); | |||
| // const svgPathNode = rc.path(lineFunction(ld.splice(0, ld.length-1)), { | |||
There was a problem hiding this comment.
Leave the lineFunction for now, we can remove it in the big PR.
Still working out some issue around it.
| @@ -606,7 +573,6 @@ export const insertEdge = function (elem, edge, clusterDb, diagramType, startNod | |||
|
|
|||
| svgPath = select(svgPathNode) | |||
| .select('path') | |||
| // .attr('d', lineFunction(lineData)) | |||
There was a problem hiding this comment.
Leave the lineFunction for now, we can remove it in the big PR.
Still working out some issue around it.
ashishjain0512
requested changes
Jul 3, 2024
…anup * 5237-unified-layout-common-renderer: (36 commits) 5237 New default width for flowchart edges #5237 Fix for rough styling of regular states and dividers in state diagrams chore: Remove "sideEffects: false" Added test for divider alignment Remove logs chore: Fix eslint errors chore: eslint autofix chore: Cleanup tsconfig chore: Fix lint Apply suggestions from code review chore: Remove extra words from cspell chore: Log granular rebuild times fix: Message wrap fix: Message wrap chore: Use `??` instead of `||` chore: Organise imports chore: Remove unused variables chore: Remove cross-env from eslint chore: Cleanup rules chore: Fix eslint issues ...
…anup * 5237-unified-layout-common-renderer: #5237 Fix fir subgraphs with elk #5237 Fix for diamond intersections with ELK, tweak #5237 Fix for diamond intersections with ELK fix for note with a composite state #5237 Handling of subgraphs using elk #5237 Handling of subgraphs using elk Fix fro direction in layout data
ashishjain0512
merged commit e63b5a7
into
5237-unified-layout-common-renderer
6 of 15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.