This repository has been archived by the owner on Nov 14, 2019. It is now read-only.
Add support for constants #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antho1404
force-pushed
the
feature/constant-support
branch
from
32be42d to
b33359c
Compare
NicolasMahe
previously approved these changes
Sep 11, 2019
krhubert
reviewed
Sep 11, 2019
package.json
Outdated
| @@ -30,7 +30,7 @@ | |||
| "is-git-url": "^1.0.0", | |||
| "js-yaml": "^3.13.1", | |||
| "lodash.pick": "^4.4.0", | |||
| "mesg-js": "^4.3.1", | |||
| "mesg-js": "github:mesg-foundation/mesg-js#build/add-mapping-constant-support", | |||
There was a problem hiding this comment.
We want rather version of mesg-js here, won't we?
There was a problem hiding this comment.
yes this is just temporary to test the feature and shouldn't be merged until the dependency mesg-foundation/mesg-js#132 is merged and released as beta. There is a dependency for this PR
krhubert
previously approved these changes
Sep 12, 2019
antho1404
dismissed stale reviews from krhubert and NicolasMahe
via
cbead1c
NicolasMahe
approved these changes
Sep 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dependency: mesg-foundation/mesg-js#132
Add compilation of constants for processes.
If the mapping contains an object with an attribute key then it is considered as a reference otherwise it is a constant