-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add constant to process map #1316
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antho1404
force-pushed
the
feature/process-map-constants
branch
from
September 11, 2019 09:42
773b0f7
to
124b4c6
Compare
antho1404
requested review from
krhubert and
NicolasMahe
and removed request for
krhubert
September 11, 2019 10:38
antho1404
force-pushed
the
feature/process-map-constants
branch
from
September 11, 2019 11:09
124b4c6
to
9509816
Compare
NicolasMahe
approved these changes
Sep 11, 2019
krhubert
reviewed
Sep 11, 2019
orchestrator/orchestrator.go
Outdated
return nil, err | ||
} | ||
if ref := output.GetRef(); ref != nil { | ||
if ref == nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ref will never be nil here (look above if check)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, got some issue with a conflict while rebasing may be coming from that.
krhubert
approved these changes
Sep 12, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support of constants for mapping.
Constants are helpful to get the user inputs, specific value, specific function for conversion using service-js, add value that is not part of any result...
It is only possible to set either a ref or a constant for a mapping.
To test:
Services
Process
You can use the CLI from this Pull Request mesg-foundation/cli#153 in order to test with the API updated