Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't access config inside container package #495

Closed
ilgooz opened this issue Sep 24, 2018 · 2 comments · Fixed by #1151
Closed

don't access config inside container package #495

ilgooz opened this issue Sep 24, 2018 · 2 comments · Fixed by #1151

Comments

@ilgooz
Copy link
Contributor

ilgooz commented Sep 24, 2018

related with #478 (review)
@ilgooz ilgooz mentioned this issue Sep 24, 2018
Merged
@krhubert krhubert mentioned this issue Sep 25, 2018
Merged
@krhubert krhubert mentioned this issue Jul 2, 2019
Merged
@NicolasMahe
Copy link
Member

Will be finally done in PR #1151 🎊

@krhubert
Copy link
Contributor

krhubert commented Jul 2, 2019

Nope, because part of container package was moved to sdk. So we need to update issue:

don't access config inside sdk package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change namespace from string slice to string mesg-foundation/engine
3 participants
@krhubert @NicolasMahe @ilgooz