Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change namespace from string slice to string #1151

Merged
merged 5 commits into from
Jul 2, 2019
Merged

Change namespace from string slice to string #1151

merged 5 commits into from
Jul 2, 2019

Conversation

krhubert
Copy link
Contributor

@krhubert krhubert commented Jul 2, 2019 •
edited by NicolasMahe
Loading

  • Use namespace prefix in container instead of accessing config.
  • Change namespace from string slice to string

closes #495

@krhubert krhubert force-pushed the refactor/container-namespace branch from 19e643c to d784f9a Compare July 2, 2019 06:24
@antho1404 antho1404 mentioned this pull request Jul 2, 2019
Closed
@krhubert
Change namespace from string slice to string
a175831 
Use namespace prefix in container instead of accessing config.
@krhubert krhubert force-pushed the refactor/container-namespace branch from d784f9a to a175831 Compare July 2, 2019 08:14
@krhubert krhubert force-pushed the refactor/container-namespace branch from d829fa1 to e833e9c Compare July 2, 2019 09:00
@krhubert krhubert requested review from NicolasMahe and antho1404 and removed request for NicolasMahe July 2, 2019 09:00
@NicolasMahe NicolasMahe mentioned this pull request Jul 2, 2019
Closed
@antho1404
Copy link
Member

let me time to test some edge cases on that one before merge

@antho1404 antho1404 merged commit 0c2ce46 into dev Jul 2, 2019
@NicolasMahe NicolasMahe deleted the refactor/container-namespace branch July 2, 2019 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasMahe NicolasMahe NicolasMahe approved these changes

@antho1404 antho1404 antho1404 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

don't access config inside container package
3 participants
@krhubert @antho1404 @NicolasMahe