Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add credential using grpc metadata #1355

Merged
merged 3 commits into from
Sep 25, 2019
Merged

Add credential using grpc metadata #1355

merged 3 commits into from
Sep 25, 2019

Conversation

NicolasMahe
Copy link
Member

Add credential system using grpc metadata for:

  • service.create
  • service.delete
  • account.delete

closes #1350

@NicolasMahe NicolasMahe added the release:add Pull requests that add something label Sep 24, 2019
@NicolasMahe NicolasMahe added this to the next milestone Sep 24, 2019
This was referenced Sep 24, 2019
Merged
Merged
Merged
antho1404
antho1404 approved these changes Sep 25, 2019
View reviewed changes
Copy link
Member

@antho1404 antho1404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small issue but that will be solved at the end of this sprint, this API crashes when we don't have the --exp flag, probably because the account sdk is not created in the deprecated mode.

@NicolasMahe NicolasMahe merged commit d568bd4 into dev Sep 25, 2019
@NicolasMahe NicolasMahe deleted the feature/metadata-sign-tx branch September 25, 2019 04:24
@NicolasMahe NicolasMahe mentioned this pull request Oct 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krhubert krhubert krhubert approved these changes

@antho1404 antho1404 antho1404 approved these changes

Assignees
No one assigned
Labels
release:add Pull requests that add something
Projects
None yet
Milestone
v0.16.0
Development

Successfully merging this pull request may close these issues.

Basic credential system
3 participants
@NicolasMahe @antho1404 @krhubert