This repository has been archived by the owner on Nov 14, 2019. It is now read-only.
Add credential system #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antho1404
suggested changes
Sep 18, 2019
There was a problem hiding this comment.
I think the grpc metadata shouldn't be known by the application using the library. We might change the authentication system or the communication layer.
Here we should pass a plain object to the create function (that we can type). This way the application will just pass plain object and doesn't have to deal with grpc metadata.
The promisify function can accept an object as metadata and create the grpc metadata object.
NicolasMahe
force-pushed
the
feature/service-metadata
branch
from
817518e to
b1a8396
Compare
NicolasMahe
force-pushed
the
feature/service-metadata
branch
from
b1a8396 to
e8b790d
Compare
antho1404
approved these changes
Sep 24, 2019
This was referenced Sep 24, 2019
krhubert
approved these changes
Sep 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add (optional) credential system to all gRPC api.
The credential object is converted to gRPC metadata.
Works with mesg-foundation/engine#1355.
Closes https://github.com/mesg-foundation/mesg-js/issues/138