Refactor cosmos modules #1650
Merged
Refactor cosmos modules #1650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krhubert
force-pushed
the
refactor/cosmos-modules
branch
from
84c0a48
to
bc2b445
Compare
krhubert
changed the title
krhubert
requested review from
NicolasMahe and
antho1404
and removed request for
NicolasMahe
- create cosmos module client - removed sdk packages - create runner/builder and event/publisher packages - remove orchestrator tests & mocks
krhubert
force-pushed
the
refactor/cosmos-modules
branch
from
5a06ec3
to
b9288be
Compare
NicolasMahe
requested changes
Feb 17, 2020
…engine into refactor/cosmos-modules
NicolasMahe
reviewed
Feb 18, 2020
|
|
||
| // Create creates a new execution. | ||
| func (s *SDK) Create(req *api.CreateExecutionRequest) (*executionpb.Execution, error) { | ||
| execution.M.Created.Add(1) |
There was a problem hiding this comment.
could be nice to have a define a shared metric object and use it across the engine
but then it's against the client / module separation
There was a problem hiding this comment.
i'm ok to merge without this 👍 @krhubert i let you merge
There was a problem hiding this comment.
They should be right im the execution. Chęci keeper się. Unfournetly i coundnt find a good place for them. We can add that to refactor list to keep track of that
NicolasMahe
approved these changes
Feb 18, 2020
NicolasMahe
added
the
release:change
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #1639
TODO: