Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showcase of execution token distribution #1666

Closed
wants to merge 2 commits into from
Closed

Conversation

krhubert
Copy link
Contributor

@krhubert krhubert commented Feb 17, 2020

dependant on #1650

Notes:

  • i've send the coins when create execution, but it could be done when update (it is just a showcase)
  • there can be only one runner owner - we should think of multiple owners.
  • I guess there is no validation for execution create - all hash could be empty

@@ -0,0 +1,26 @@
package reciver
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
package reciver
package receiver

servicePrice = append(servicePrice, coin)
}

if err := k.bankKeeper.SendCoins(ctx, msg.Signer, reciver.Reciver, runnerPrice); err != nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

who is reciver.Reciver?

@NicolasMahe
Copy link
Member

the transfer is correctly done:
localhost_3000_txs_DE37368B71EAA19A787F84948E659AE490EA5B89E199BFC350CB1B6AABB805E6(iPad)

➜  engine git:(feature/execution-price) ./bin/mesg-cli query account mesgtest1gzr4f4psys5ezcwcelp3sy855scasglch507c7 -o text
|
  address: mesgtest1gzr4f4psys5ezcwcelp3sy855scasglch507c7
  coins:
  - denom: atto
    amount: "20"
  public_key: ""
  account_number: 5
  sequence: 0

@antho1404
Copy link
Member

didn't we say that we should attach a balance to the service and transfer to this balance and not directly the user

@NicolasMahe NicolasMahe changed the title Showcase of exeuction token distribution Showcase of execution token distribution Feb 19, 2020
@NicolasMahe
Copy link
Member

didn't we say that we should attach a balance to the service and transfer to this balance and not directly the user

From the description:

i've send the coins when create execution, but it could be done when update (it is just a showcase)

@NicolasMahe
Copy link
Member

@krhubert you forget to close this PR:
from the forum:

close #1666 2 in favor of #1670

@NicolasMahe NicolasMahe deleted the feature/execution-price branch February 19, 2020 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants