Add core api #235
Merged
Add core api #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #235 +/- ##
==========================================
+ Coverage 63.85% 64.01% +0.15%
==========================================
Files 74 76 +2
Lines 1627 1637 +10
==========================================
+ Hits 1039 1048 +9
+ Misses 508 507 -1
- Partials 80 82 +2
Continue to review full report at Codecov.
|
Merged
NicolasMahe
reviewed
Jun 17, 2018
api/core/api.proto
Outdated
| @@ -13,6 +13,8 @@ service Core { | |||
| rpc StopService (StopServiceRequest) returns (StopServiceReply) {} | |||
| rpc DeployService (DeployServiceRequest) returns (DeployServiceReply) {} | |||
| rpc DeleteService (DeleteServiceRequest) returns (DeleteServiceReply) {} | |||
| rpc ListServices (ListServicesRequest) returns (ListServicesReply) {} | |||
| rpc Service (ServiceRequest) returns (ServiceReply) {} | |||
There was a problem hiding this comment.
I suggest to rename Service by GetService. It will be better for the uniformization and explicitly of the API
There was a problem hiding this comment.
Don't forget to rename the files api/core/service.go and api/core/service_test.go.
NicolasMahe
approved these changes
Jun 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the following APIs
rpc ListServices (ListServicesRequest) returns (ListServicesReply) {}rpc GetService (ServiceRequest) returns (ServiceReply) {}