Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cli with new api #236

Merged
merged 4 commits into from
Jun 17, 2018
Merged

Update cli with new api #236

merged 4 commits into from
Jun 17, 2018

Conversation

antho1404
Copy link
Member

depends on #235

#191

@antho1404 antho1404 self-assigned this Jun 17, 2018
@antho1404 antho1404 requested a review from NicolasMahe June 17, 2018 08:00
@codecov
Copy link

codecov bot commented Jun 17, 2018

Codecov Report

Merging #236 into dev will increase coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #236      +/-   ##
==========================================
+ Coverage   64.03%   64.06%   +0.02%     
==========================================
  Files          75       75              
  Lines        1635     1625      -10     
==========================================
- Hits         1047     1041       -6     
+ Misses        505      503       -2     
+ Partials       83       81       -2
Impacted Files Coverage Δ
cmd/service/detail.go 0% <0%> (ø) ⬆️
cmd/service/list.go 68.75% <0%> (ø) ⬆️
cmd/service/logs.go 15.38% <0%> (+2.88%) ⬆️
cmd/service/delete.go 7.14% <0%> (ø) ⬆️
api/service/submit_result.go 81.81% <0%> (-3.9%) ⬇️
service/import.go 100% <0%> (+25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8899e80...f57798e. Read the comment docs.

…li-with-new-api

# Conflicts:
#	CHANGELOG.md
#	cmd/service/list.go
@NicolasMahe NicolasMahe merged commit 496ad16 into dev Jun 17, 2018
@NicolasMahe NicolasMahe deleted the update-cli-with-new-api branch June 17, 2018 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants