Init commit of MarkdownWriter class #163
Conversation
Codecov ReportPatch and project coverage have no change.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #163 +/- ##
=======================================
Coverage 96.55% 96.55%
=======================================
Files 12 12
Lines 261 261
=======================================
Hits 252 252
Misses 9 9 ☔ View full report in Codecov by Sentry. |
Packing analysis reportAnalysis for packing results located at cellpack/tests/outputs/test_spheres/spheresSST
Packing image
Distance analysisExpected minimum distance: 50.00
|
|
Looks like the tables are missing headers (check github bot comments on other PRs to identify missing headers) |
| self.report_md.new_line( | ||
| self.report_md.new_inline_image( | ||
| text=image_text[i], | ||
| path=str(self.output_path / filepaths[i]) |
There was a problem hiding this comment.
We want this to be output_image_location and not output_path. The distinction is as follows:
output_image_locationrefers to the path used in the report to link to the image. This can be the AWS bucket path after the github workflow runs.output_pathis the path to which the markdown file itself is written. This is typically the root directory where packing outputs are stored.
…(create_report and associated methods)
aditnath
force-pushed
the
feature/markdown_class
branch
from
d6c96df to
4be1e5d
Compare
|
Issued resolved in #276 |
Creating a generic markdown writer class in the cellpack writers repo