Feature/markdown class #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ture/markdown-class
…ture/markdown-class
rugeli
force-pushed
the
feature/markdown-class
branch
2 times, most recently
from
0ff5204 to
bcab5b4
Compare
Packing analysis reportAnalysis for packing results located at cellpack/tests/outputs/test_spheres/spheresSST
Packing imageDistance analysisExpected minimum distance: 50.00
|
|
Note: This is a WIP. I'll request reviews once the images and markdown file formatting are adjusted. |
mogres
approved these changes
Aug 1, 2024
| @@ -431,3 +435,108 @@ def save( | |||
| self.save_as_simularium(env, seed_to_results_map) | |||
| else: | |||
| print("format output " + output_format + " not recognized (json,python)") | |||
|
|
|||
There was a problem hiding this comment.
Do we want this in __init__.py? I feel like this could be moved to a separate file MarkdownWriter.py in the same folder
|
|
||
| with open(report_path, "r") as f: | ||
| report = f.read() | ||
| assert "Test Image" in report |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is the problem this work solves, including
closes #135
Solution
What I/we did to solve this problem
MarkdownWriterthat writes markdown files (incorporating some old code from Init commit of MarkdownWriter class #163)Type of change
Please delete options that are not relevant.
Steps to Verify:
MarkdownWriterpytest cellpack/tests/test_markdown_writer.py