Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow defining groups of genomes in input file. #82

Merged
merged 19 commits into from
Apr 24, 2024
Merged

Allow defining groups of genomes in input file. #82

merged 19 commits into from
Apr 24, 2024

Conversation

njohner
Copy link
Contributor

@njohner njohner commented Apr 24, 2024

With this PR we introduce the possibility of defining groups of genomes.

For now the groups can only be defined in the input CSV file and they can only be used in the GWAS view.

Also note that we are no longer handling errors ourselves in the GWAS view, but let django forms take care of error handling. This has the advantage that field validation errors will get displayed on that particular field in the form, whereas other form validation errors (e.g. depending on several fields) will be displayed at the top of the form, as seen in the screenshots below. I plan on refactoring all forms in the future to apply this approach.

I will continue to work on this feature in future commits, notably to enable the use of the groups in other views, add the possibility to add and edit groups and add a group details view.

gwas_form_error
gwas_form_error2

Checklist

  • Changelog entry
  • Check that tests still pass
  • Add tests for new features and regression tests for bugfixes whenever possible.

@njohner njohner marked this pull request as ready for review April 24, 2024 08:46
@njohner njohner merged commit 929e3a8 into master Apr 24, 2024
@njohner njohner deleted the nj/groups branch April 24, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant