-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow defining groups of genomes in input file. #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parsing the csv file is now done during initialization of the class as well as defining several instance attributes.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we introduce the possibility of defining groups of genomes.
For now the groups can only be defined in the input CSV file and they can only be used in the GWAS view.
Also note that we are no longer handling errors ourselves in the GWAS view, but let django forms take care of error handling. This has the advantage that field validation errors will get displayed on that particular field in the form, whereas other form validation errors (e.g. depending on several fields) will be displayed at the top of the form, as seen in the screenshots below. I plan on refactoring all forms in the future to apply this approach.
I will continue to work on this feature in future commits, notably to enable the use of the groups in other views, add the possibility to add and edit groups and add a group details view.
Checklist