Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display form validation errors next to the corresponding fields. #83

Merged
merged 19 commits into from
Apr 26, 2024
Merged

Display form validation errors next to the corresponding fields. #83

merged 19 commits into from
Apr 26, 2024

Conversation

njohner
Copy link
Contributor

@njohner njohner commented Apr 25, 2024 •
edited
Loading

Instead of doing custom error handling in the forms, we now use the default django forms behavior. This is much better as the errors get displayed next to the corresponding fields whenever possible, i.e. when validation fails for a specific field, the error will get displayed there, for other errors, we end up with an error message in a banner above the form, as we had before. See screenshot below and screenshots in #82 for more examples.

We also add more error handling for the custom plots view and improve the blast view notably by displaying the help as to what is expected in the "blast input" field as a placeholder in the TextArea widget.

venn_error

Checklist

  • Changelog entry
  • Check that tests still pass
  • Add tests for new features and regression tests for bugfixes whenever possible.

@njohner njohner marked this pull request as ready for review April 25, 2024 13:07
@njohner
Use validators instead of custom error handling for venn form.
bd7b251 
Some of the changes belonging to this commit were unfortunately
already merged by mistake and can be found in commit
853b796.
@njohner
Handle errors with form validation in hit extraction views.
1fd8c7a
@njohner
Make targets field mandatory in MetaboForm.
a215843 
It does not make sense to allow tabular comparison with no targets.
@njohner
Remove unused add_box parameter for MetaboForm.
aae46ea
njohner and others added 15 commits April 26, 2024 13:15
@njohner
Handle errors with form validation in plot heatmap views.
bc57cdb
@njohner
Handle errors with form validation in pan genomes views.
c741997
@njohner
Handle errors with form validation in cog_barchart view.
745cf7c
@njohner
Move phenotype validation to form for GWAS views.
e3ca328
@njohner
Handle errors with form validation in plot_region view.
5d95c3c
@njohner
Use form error handling for circos and kegg views.
d0b5ce3
@njohner
Handle errors with form validation in blast view.
72b82e1
@njohner
Improve blast form by using crispy form.
143d26e
@njohner
Improve custom plots form.
c561268
@njohner
Format blast.html template.
647f7a6
@njohner
Improve styling of blast view.
d0c9138 
We style the view in the same manner as other results view are styled.
@njohner
Add changelog.
23013fe
@njohner
Handle errors with form validation in custom plots view.
e1d6cdc
@njohner
Clean-up unused error messages.
2b7ff15
@njohner
Handle invalid entries in custom plots view.
47c3e27
@njohner njohner merged commit cda062a into master Apr 26, 2024
@njohner njohner deleted the nj/forms branch April 26, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@njohner