-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle groups in hit extraction view. #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces a new argument exclude_taxids_in_groups to AccessionFieldHandler.get_choices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we add the possibility to select groups to define the included and excluded genomes in the hit extraction view.
Because this makes displaying the possible choices more difficult, we delegate this to the backend by introducing the
django autocomplete light
package. This package will use Ajax requests to ask the backend for updated lists of available choices, depending on other fields in the form. We therefore add two new views responsible for providing the choices for selecting genomes and for selecting the number ofMissing data
allowed.I'm not quite sure how selecting groups should behave when "Distinguish plasmids from chromosomes" is enabled. For now, selecting a group will select the corresponding taxons but not the plasmids.
Checklist