Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle groups in hit extraction view. #84

Merged
merged 17 commits into from
May 2, 2024
Merged

Handle groups in hit extraction view. #84

merged 17 commits into from
May 2, 2024

Conversation

njohner
Copy link
Contributor

@njohner njohner commented May 2, 2024

With this PR we add the possibility to select groups to define the included and excluded genomes in the hit extraction view.

Because this makes displaying the possible choices more difficult, we delegate this to the backend by introducing the django autocomplete light package. This package will use Ajax requests to ask the backend for updated lists of available choices, depending on other fields in the form. We therefore add two new views responsible for providing the choices for selecting genomes and for selecting the number of Missing data allowed.

I'm not quite sure how selecting groups should behave when "Distinguish plasmids from chromosomes" is enabled. For now, selecting a group will select the corresponding taxons but not the plasmids.

extraction_form_groups

Checklist

  • Changelog entry
  • Check that tests still pass
  • Add tests for new features and regression tests for bugfixes whenever possible.

@njohner njohner changed the title Nj/dal Handle groups in hit extraction view. May 2, 2024
@njohner njohner marked this pull request as ready for review May 2, 2024 09:50
@njohner njohner merged commit 0ef129e into master May 2, 2024
@njohner njohner deleted the nj/dal branch May 2, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant