Remove dns-controller-manager subcomponent from release vector #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The shoot-dns extension ships with the proper version of this component. We do not need to allow overrides for this.
Gerrit91
changed the title
Gerrit91
changed the title
control-plane/roles/gardener/templates/shoot-dns-service/controller-deployment.yaml
Outdated
Show resolved
Hide resolved
robertvolkmann
requested changes
Oct 16, 2024
control-plane/roles/gardener/templates/shoot-dns-service/controller-deployment.yaml
Outdated
Show resolved
Hide resolved
|
Overwriting the image vector has not the desired effect because the image of the |
…oller-deployment.yaml Co-authored-by: Robert Volkmann <20912167+robertvolkmann@users.noreply.github.com>
robertvolkmann
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The shoot-dns extension ships with the proper version of this component. In order not to have to maintain this dependency anymore, we remove the override from our release vector. Instead an operator can now manually provide an overwrite.
Required Actions