Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dns-controller-manager subcomponent from release vector #337

Merged
merged 6 commits into from
Oct 21, 2024
Merged

Remove dns-controller-manager subcomponent from release vector #337

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
347df8c
Remove dns-controller-manager override.
Gerrit91 Oct 16, 2024
875bd8e
Add possibility to overwrite again.
Gerrit91 Oct 16, 2024
99ad671
Indent properly.
Gerrit91 Oct 16, 2024
64118db
Update control-plane/roles/gardener/templates/shoot-dns-service/contr…
Gerrit91 Oct 21, 2024
922b02e
Add test.
Gerrit91 Oct 21, 2024
012e947
Missing defaults.
Gerrit91 Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions control-plane/roles/gardener/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ This includes the metal-stack extension provider called [gardener-extension-prov
| gardener_cert_management_issuer_server | | The issuer server used by the cert-management extension |
| gardener_cert_management_precheck_nameservers | | To provide special set of nameservers to be used for prechecking DNSChallenges for an issuer |
| gardener_cert_management_shoot_issuers_enabled | | If enabled, allows to specify issuers in the shoot clusters |
| gardener_shoot_dns_service_image_vector_overwrite | | Allows overriding the image vector for the shoot-dns-service extension |

### Certificates

Expand Down
6 changes: 6 additions & 0 deletions control-plane/roles/gardener/defaults/main/extensions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,3 +78,9 @@ gardener_extension_networking_cilium_image_vector_overwrite: []
# sourceRepository: /source/repository
# repository: /repository
# tag: <tag>

gardener_shoot_dns_service_image_vector_overwrite: []
# - name: dns-controller-manager
# sourceRepository: github.com/gardener/external-dns-management
# repository: europe-docker.pkg.dev/gardener-project/public/dns-controller-manager
# tag: "0.7.1"
7 changes: 4 additions & 3 deletions control-plane/roles/gardener/templates/shoot-dns-service/controller-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,11 @@ providerConfig:
image:
repository: "{{ gardener_shoot_dns_service_image_name }}"
tag: "{{ gardener_shoot_dns_service_image_tag }}"
{% if gardener_shoot_dns_service_image_vector_overwrite %}
imageVectorOverwrite:
Gerrit91 marked this conversation as resolved.
Show resolved Hide resolved
images: "{{ gardener_shoot_dns_service_image_vector_overwrite | to_json }}"
Gerrit91 marked this conversation as resolved.
Show resolved Hide resolved
{% endif %}
dnsProviderManagement:
enabled: true
dnsControllerManager:
image:
tag: "{{ gardener_dns_controller_manager_image_tag }}"
repository: "{{ gardener_dns_controller_manager_image_name }}"
deploy: true
2 changes: 0 additions & 2 deletions defaults/main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,6 @@ metal_stack_release:
gardener_shoot_cert_service_image_name: "docker-images.third-party.gardener.shoot-cert-service.name"
gardener_shoot_dns_service_image_tag: "docker-images.third-party.gardener.shoot-dns-service.tag"
gardener_shoot_dns_service_image_name: "docker-images.third-party.gardener.shoot-dns-service.name"
gardener_dns_controller_manager_image_tag: "docker-images.third-party.gardener.dns-controller-manager.tag"
gardener_dns_controller_manager_image_name: "docker-images.third-party.gardener.dns-controller-manager.name"
gardener_metrics_exporter_image_tag: "docker-images.third-party.gardener.metrics-exporter.tag"
gardener_metrics_exporter_image_name: "docker-images.third-party.gardener.metrics-exporter.name"
gardener_extension_acl_image_name: "docker-images.third-party.gardener.acl-extension.name"
Expand Down
Loading