Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip cleanup after each e2e test when SKIP_RESOURCE_CLEANUP is set #1629

Closed
lentzi90 opened this issue Mar 20, 2024 · 3 comments · Fixed by #1641
Closed

Skip cleanup after each e2e test when SKIP_RESOURCE_CLEANUP is set #1629

lentzi90 opened this issue Mar 20, 2024 · 3 comments · Fixed by #1641
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. triage/accepted Indicates an issue is ready to be actively worked on.

Comments

@lentzi90
Copy link
Member

Currently we skip cleanup of the management cluster if the variable is set but each individual test still does a cleanup.
Make all tests respect the variable so that no cleanup is done when it is set to true.

For each test here, look for the cleanup and make it so that it is skipped if asked for.

@lentzi90
Copy link
Member Author

/good-first-issue
/triage accepted

@metal3-io-bot
Copy link
Contributor

@lentzi90:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue
/triage accepted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot added triage/accepted Indicates an issue is ready to be actively worked on. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Mar 20, 2024
@NeerajNagure
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. triage/accepted Indicates an issue is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants