Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 check for skipCleanup before running cleanup of test resources #1641

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

NeerajNagure
Copy link
Contributor

What this PR does / why we need it:
Checks whether the skipCleanup variable is true or not.If true,it skips the cleanup of the test resources

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1629

Signed-off-by: Neeraj Nagure <nagureneeraj@gmail.com>
@metal3-io-bot metal3-io-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 28, 2024
@metal3-io-bot
Copy link
Contributor

Hi @NeerajNagure. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 28, 2024
@lentzi90
Copy link
Member

lentzi90 commented Apr 3, 2024

/ok-to-test

@metal3-io-bot metal3-io-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 3, 2024
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!
/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2024
@NeerajNagure
Copy link
Contributor Author

/test metal3-bmo-e2e-test-pull

@NeerajNagure
Copy link
Contributor Author

NeerajNagure commented Apr 3, 2024

/test test-centos-e2e-integration-main

@tuminoid
Copy link
Member

tuminoid commented Apr 3, 2024

/retitle 🌱 check for skipCleanup before running cleanup of test resources

@metal3-io-bot metal3-io-bot changed the title 🌱 :checked for skipCleanup before running cleanup of test resources 🌱 check for skipCleanup before running cleanup of test resources Apr 3, 2024
@NeerajNagure
Copy link
Contributor Author

/test-centos-e2e-integration-main

Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for the contribution!

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2024
@tuminoid
Copy link
Member

tuminoid commented Apr 3, 2024

/test-centos-e2e-integration-main

@metal3-io-bot metal3-io-bot merged commit fe431f3 into metal3-io:main Apr 3, 2024
21 checks passed
@NeerajNagure NeerajNagure deleted the skip-cleanup branch April 4, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip cleanup after each e2e test when SKIP_RESOURCE_CLEANUP is set
4 participants