Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Golang to 1.23 and golangci-lint to 1.60.x #2009

Closed
tuminoid opened this issue Oct 22, 2024 · 6 comments · Fixed by #2069
Closed

Bump Golang to 1.23 and golangci-lint to 1.60.x #2009

tuminoid opened this issue Oct 22, 2024 · 6 comments · Fixed by #2069
Assignees
@tuminoid
Labels
dependencies Pull requests that update a dependency file kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue is ready to be actively worked on.

Comments

@tuminoid
Copy link
Member

tuminoid commented Oct 22, 2024 •
edited
Loading

Bump Golang to 1.23 before next minor release as 1.22 support will end in 4 months.

Release notes should be checked for any changes that might affect the repo.

NOTE: do not bump go.mod versions for the sake of bumping. They shall be bumped only if language features using Go 1.23 are used in code, or by dependencies force it.

Golangci-lint needs to be bumped to 1.60.1 or newer for golang 1.23 support. It adds some new errors and linters. White list need to be verified to be complete and correct.

What to expect: CAPM3 bump PR

/kind feature
@metal3-io-bot metal3-io-bot added kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Oct 22, 2024
@Rozzii
Copy link
Member

Rozzii commented Oct 23, 2024

/triage accepted
/kind dependency

@metal3-io-bot
Copy link
Contributor

@Rozzii: The label(s) kind/dependency cannot be applied, because the repository doesn't have them.

In response to this:

/triage accepted
/kind dependency

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot added triage/accepted Indicates an issue is ready to be actively worked on. and removed needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Oct 23, 2024
@Rozzii
Copy link
Member

Rozzii commented Oct 23, 2024

/kind dependencies

@metal3-io-bot
Copy link
Contributor

@Rozzii: The label(s) kind/dependencies cannot be applied, because the repository doesn't have them.

In response to this:

/kind dependencies

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Rozzii Rozzii added the dependencies Pull requests that update a dependency file label Oct 23, 2024
@tuminoid tuminoid changed the title Bump Golang to 1.23 Bump Golang to 1.23 and golangci-lint to 1.60.x Nov 11, 2024
@tuminoid
Copy link
Member Author

Added golangci-lint part as required part.

@tuminoid
Copy link
Member Author

/assign

@tuminoid tuminoid mentioned this issue Nov 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tuminoid tuminoid

Labels
dependencies Pull requests that update a dependency file kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🌱 Bump Go to 1.23.3 and golangci-lint to 1.60.3 Nordix/baremetal-operator
3 participants
@tuminoid @Rozzii @metal3-io-bot