🌱 Bump Go to 1.23.3 and golangci-lint to 1.60.3 #2069
Merged
+30
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metal3-io-bot
added
the
size/M
Bump Go to 1.23.3 and golangci-lint to 1.60.3 which supports Go 1.23. Ignore couple new warnings that are generated, as there is no immediate good options. Cleanup golangci-lint config from deprecated configs. Include timeouts where needed, golangci-lint 1.60 is defaulting to real short runs and failing otherwise. Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
tuminoid
force-pushed
the
tuomo/bump-golang-1.23-and-golangcilint
branch
from
6418f3c
to
2b548b8
Compare
|
/cc @lentzi90 @kashifest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump Go to 1.23.3 and golangci-lint to 1.60.3 which supports Go 1.23.
Ignore couple new warnings that are generated, as there is no immediate good options. Fix some of the new issues.
Cleanup golangci-lint config from deprecated configs.
Include timeouts where needed, golangci-lint 1.60 is defaulting to real short runs and failing otherwise.
Fixes: #2009