Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Bump Go to 1.23.3 and golangci-lint to 1.60.3 #2070

Merged

Conversation

tuminoid
Copy link
Member

Bump Go to 1.23.3 and golangci-lint to 1.60.3 which supports Go 1.23.

Ignore couple new warnings that are generated, as there is no immediate good options.

Cleanup golangci-lint config from deprecated configs.

Include timeouts where needed, golangci-lint 1.60 is defaulting to real short runs and failing otherwise.

Manual cherry-pick of #2069 due conflict in golangci-lint config.

/hold
until #2069 is merged, so they can be merged as identical.

Bump Go to 1.23.3 and golangci-lint to 1.60.3 which supports Go 1.23.

Ignore couple new warnings that are generated, as there is no immediate
good options.

Cleanup golangci-lint config from deprecated configs.

Include timeouts where needed, golangci-lint 1.60 is defaulting to
real short runs and failing otherwise.

Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 20, 2024
@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 20, 2024
@dtantsur
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2024
@tuminoid
Copy link
Member Author

/cc @lentzi90
/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 21, 2024
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2024
@metal3-io-bot metal3-io-bot merged commit 0db0914 into metal3-io:release-0.8 Nov 21, 2024
19 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/bump-golang-1.23-in-0.8 branch November 21, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants