Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fixes for HostFirmwareComponents #1655

Merged
merged 1 commit into from
Apr 12, 2024
Merged

🐛 Fixes for HostFirmwareComponents #1655

merged 1 commit into from
Apr 12, 2024

Conversation

iurygregory
Copy link
Member

This commit is to address some feedback from #1559.

  • Automatically create the HFC for the BMH
  • GetFirmwareComponents now takes into consideration that an empty list was returned and will only throw an error if the FirmwareInterface is different from redfish.

What this PR does / why we need it: metal3-io/metal3-docs#364

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 8, 2024
@iurygregory iurygregory mentioned this pull request Apr 8, 2024
Merged
@metal3-io-bot metal3-io-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 9, 2024
@iurygregory
Copy link
Member Author

/test metal3-bmo-e2e-test-pull
/test-centos-e2e-integration-main

elfosardo
elfosardo reviewed Apr 10, 2024
View reviewed changes
pkg/provisioner/ironic/ironic.go Outdated Show resolved Hide resolved
controllers/metal3.io/baremetalhost_controller.go Outdated Show resolved Hide resolved
@iurygregory
Copy link
Member Author

/test metal3-bmo-e2e-test-pull
/test-centos-e2e-integration-main

@iurygregory
Copy link
Member Author

/test metal3-bmo-e2e-test-pull

@iurygregory iurygregory requested a review from elfosardo April 10, 2024 16:55
@iurygregory
Copy link
Member Author

/test metal3-bmo-e2e-test-pull
/test-centos-e2e-integration-main

@dtantsur
Copy link
Member

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2024
@tuminoid
Copy link
Member

Could the title be changed from HFC to HostFirmwareComponents for release note clarity?

@iurygregory iurygregory changed the title 🐛 Fixes in HFC 🐛 Fixes in HostFirmwareComponents Apr 11, 2024
@iurygregory
Copy link
Member Author

@tuminoid done

Rozzii
Rozzii previously approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2024
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur, Rozzii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Rozzii
Copy link
Member

Rozzii commented Apr 11, 2024

/test-centos-e2e-integration-main

1 similar comment
@dtantsur
Copy link
Member

/test-centos-e2e-integration-main

@mboukhalfa
Copy link
Member

/test ?

@metal3-io-bot
Copy link
Contributor

@mboukhalfa: The following commands are available to trigger required jobs:

  • /test generate
  • /test gomod
  • /test manifestlint
  • /test markdownlint
  • /test metal3-bmo-e2e-test-pull
  • /test shellcheck
  • /test test
  • /test unit

The following commands are available to trigger optional jobs:

  • /test metal3-bmo-e2e-test-optional-pull
  • /test metal3-centos-e2e-basic-test-main
  • /test metal3-centos-e2e-feature-test-main
  • /test metal3-centos-e2e-integration-test-main
  • /test metal3-e2e-1-26-1-27-upgrade-test-main
  • /test metal3-e2e-1-27-1-28-upgrade-test-main
  • /test metal3-e2e-1-28-1-29-upgrade-test-main
  • /test metal3-e2e-clusterctl-upgrade-test-main
  • /test metal3-keep-e2e-1-26-1-27-upgrade-test-main
  • /test metal3-keep-e2e-1-27-1-28-upgrade-test-main
  • /test metal3-keep-e2e-1-28-1-29-upgrade-test-main
  • /test metal3-keep-e2e-clusterctl-upgrade-test-main
  • /test metal3-ubuntu-e2e-basic-test-main
  • /test metal3-ubuntu-e2e-feature-test-main
  • /test metal3-ubuntu-e2e-integration-test-main

Use /test all to run the following jobs that were automatically triggered:

  • generate
  • gomod
  • manifestlint
  • unit

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mboukhalfa
Copy link
Member

/test metal3-centos-e2e-integration-test-main

@iurygregory
Copy link
Member Author

/test metal3-bmo-e2e-test-pull

@iurygregory
Copy link
Member Author

/retest

@iurygregory
Copy link
Member Author

/test-centos-e2e-integration-main

@iurygregory iurygregory changed the title 🐛 Fixes in HostFirmwareComponents 🐛 Fixes for HostFirmwareComponents Apr 11, 2024
@iurygregory
Copy link
Member Author

/test metal3-bmo-e2e-test-pull
/test metal3-centos-e2e-integration-test-main

@iurygregory
Fixes in HFC
fafe7fa 
This commit is to address some feedback from metal3-io#1559.

- Automatically create the HFC for the BMH
- GetFirmwareComponents now takes into consideration that
  an empty list was returned and will only throw an error if
  the FirmwareInterface is different from `no-firmware`.
- extended PrepareData to contain the TargetFirmwareComponents
- actionPreparing takes into account the HFC

Signed-off-by: Iury Gregory Melo Ferreira <imelofer@redhat.com>
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2024
@dtantsur
Copy link
Member

/test metal3-bmo-e2e-test-pull
/test metal3-centos-e2e-integration-test-main

@iurygregory
Copy link
Member Author

/test metal3-centos-e2e-integration-test-main
/test metal3-bmo-e2e-test-pull

@dtantsur
Copy link
Member

Ehhmm, bad copy-paste

/test-centos-e2e-integration-main

@mboukhalfa
Copy link
Member

/override test-centos-e2e-integration-main
https://jenkins.nordix.org/view/Metal3/job/metal3_bmo_main_e2e_integration_test_centos/491/
as it got passed but not reporting that on github

@metal3-io-bot
Copy link
Contributor

@mboukhalfa: mboukhalfa unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file.

In response to this:

/override test-centos-e2e-integration-main
https://jenkins.nordix.org/view/Metal3/job/metal3_bmo_main_e2e_integration_test_centos/491/
as it got passed but not reporting that on github

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lentzi90
lentzi90 reviewed Apr 12, 2024
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2024
@lentzi90
Copy link
Member

/override test-centos-e2e-integration-main
Test already passed. We are just having issues getting the status reported...

@metal3-io-bot
Copy link
Contributor

@lentzi90: Overrode contexts on behalf of lentzi90: test-centos-e2e-integration-main

In response to this:

/override test-centos-e2e-integration-main
Test already passed. We are just having issues getting the status reported...

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot merged commit b9c00f0 into metal3-io:main Apr 12, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

@dtantsur dtantsur dtantsur left review comments

@Rozzii Rozzii Rozzii left review comments

@elfosardo elfosardo Awaiting requested review from elfosardo

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@iurygregory @dtantsur @tuminoid @metal3-io-bot @Rozzii @mboukhalfa @lentzi90 @elfosardo