Firmware Interface proposal #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metal3-io-bot
added
the
size/L
iurygregory
force-pushed
the
firmware-interface
branch
from
109e71b to
7206c85
Compare
|
/retitle Firmware Interface proposal |
metal3-io-bot
changed the title
dtantsur
reviewed
Oct 30, 2023
dtantsur
reviewed
Oct 30, 2023
dtantsur
reviewed
Oct 30, 2023
dtantsur
reviewed
Oct 30, 2023
dtantsur
reviewed
Oct 30, 2023
dtantsur
reviewed
Oct 30, 2023
dtantsur
reviewed
Oct 30, 2023
dtantsur
reviewed
Oct 30, 2023
dtantsur
reviewed
Oct 30, 2023
dtantsur
reviewed
Oct 30, 2023
dtantsur
reviewed
Oct 30, 2023
iurygregory
force-pushed
the
firmware-interface
branch
from
7206c85 to
4bdfa84
Compare
elfosardo
reviewed
Nov 8, 2023
iurygregory
force-pushed
the
firmware-interface
branch
2 times, most recently
from
986081e to
8cd2a4b
Compare
|
@elfosardo @dtantsur if you think I need to update more things here, let me know. |
iurygregory
force-pushed
the
firmware-interface
branch
from
8cd2a4b to
5bd082f
Compare
dtantsur
reviewed
Nov 20, 2023
dtantsur
reviewed
Nov 20, 2023
dtantsur
reviewed
Nov 20, 2023
dtantsur
reviewed
Nov 20, 2023
| - Verify that updates can be executed on two type of hardware that supports | ||
| Redfish. | ||
| - Verify that the information about the desired version is available after | ||
| cleaning. |
There was a problem hiding this comment.
BMO has new e2e tests (check the commit history). That allows us to test firmware upgrades against sushy-tools. WDYT?
There was a problem hiding this comment.
Hummm that could be a thing, but sushy-tools currently doesn't have the capability to execute firmware updates.
There was a problem hiding this comment.
@mquhuy @mboukhalfa This might be interesting feature for you to implement in susy tools or to anyone in our team @kashifest
|
/approve I think we're at the point where the details can be polished in the code (but I'd still appreciate my comments addressed). |
metal3-io-bot
added
the
approved
Signed-off-by: Iury Gregory Melo Ferreira <imelofer@redhat.com>
iurygregory
force-pushed
the
firmware-interface
branch
from
5bd082f to
9da24dc
Compare
Rozzii
approved these changes
Nov 21, 2023
| - Verify that updates can be executed on two type of hardware that supports | ||
| Redfish. | ||
| - Verify that the information about the desired version is available after | ||
| cleaning. |
There was a problem hiding this comment.
@mquhuy @mboukhalfa This might be interesting feature for you to implement in susy tools or to anyone in our team @kashifest
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur, Rozzii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
iurygregory
added a commit
to iurygregory/baremetal-operator
that referenced
this pull request
Dec 29, 2023
Add a new CRD for the HostFirmwareComponents described in the Firmware Interface proposal - metal3-io/metal3-docs#364.
iurygregory
added a commit
to iurygregory/baremetal-operator
that referenced
this pull request
Dec 29, 2023
Add a new CRD for the HostFirmwareComponents described in the Firmware Interface proposal - metal3-io/metal3-docs#364. Signed-off-by: Iury Gregory Melo Ferreira <imelofer@redhat.com>
iurygregory
added a commit
to iurygregory/baremetal-operator
that referenced
this pull request
Jan 15, 2024
Add a new CRD for the HostFirmwareComponents described in the Firmware Interface proposal - metal3-io/metal3-docs#364. Signed-off-by: Iury Gregory Melo Ferreira <imelofer@redhat.com>
iurygregory
added a commit
to iurygregory/baremetal-operator
that referenced
this pull request
Jan 15, 2024
Add a new CRD for the HostFirmwareComponents described in the Firmware Interface proposal - metal3-io/metal3-docs#364. Signed-off-by: Iury Gregory Melo Ferreira <imelofer@redhat.com>
iurygregory
added a commit
to iurygregory/baremetal-operator
that referenced
this pull request
Jan 18, 2024
Add a new CRD for the HostFirmwareComponents described in the Firmware Interface proposal - metal3-io/metal3-docs#364. Signed-off-by: Iury Gregory Melo Ferreira <imelofer@redhat.com>
iurygregory
added a commit
to iurygregory/baremetal-operator
that referenced
this pull request
Jan 18, 2024
Add a new CRD for the HostFirmwareComponents described in the Firmware Interface proposal - metal3-io/metal3-docs#364. Signed-off-by: Iury Gregory Melo Ferreira <imelofer@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.