🌱 add scaffolding for go bump to 1.22 #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metal3-io-bot
added
the
size/M
tuminoid
commented
Jun 10, 2024
hack/gomod.sh
Outdated
| @@ -39,6 +39,6 @@ else | |||
| --volume "${PWD}:/workdir:ro,z" \ | |||
| --entrypoint sh \ | |||
| --workdir /workdir \ | |||
| docker.io/golang:1.21 \ | |||
| docker.io/golang:1.22 \ | |||
There was a problem hiding this comment.
This should be part of #42 actually, and not be here.
- Add "make go-version" in Makefile to easily access used Go version - Add setup-go steps to functional and build workflows that setup the correct version of Go This should allow the actual bump to golang 1.22 to succeed. Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
tuminoid
force-pushed
the
tuomo/add-scaffolding-for-go-1.22
branch
from
ca4d9c9
to
d2299db
Compare
Merged
|
/approve Thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump gomod prow test to 1.22 (pairs with PR in project-infra: bump go 1.22 for ironic-standalone-operator project-infra#783)This should allow the actual bump to golang 1.22 to succeed in #42