Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump go 1.22 for ironic-standalone-operator #783

Merged
merged 1 commit into from
Jun 10, 2024
Merged

bump go 1.22 for ironic-standalone-operator #783

merged 1 commit into from
Jun 10, 2024

Conversation

tuminoid
Copy link
Member

Bump Go image to 1.22 for ironic-standalone-operator tests, as we're bumping Go to 1.22 there.

@tuminoid
bump go 1.22 for ironic-standalone-operator
f6902ce 
Bump Go image to 1.22 for ironic-standalone-operator tests, as we're
bumping Go to 1.22 there.

Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 10, 2024
@tuminoid
Copy link
Member Author

/override metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Collaborator

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tuminoid tuminoid mentioned this pull request Jun 10, 2024
Merged
smoshiur1237
smoshiur1237 reviewed Jun 10, 2024
View reviewed changes
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2024
@tuminoid
Copy link
Member Author

/cc @kashifest

@tuminoid tuminoid mentioned this pull request Jun 10, 2024
Merged
kashifest
kashifest reviewed Jun 10, 2024
View reviewed changes
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2024
@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur, kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot merged commit e026524 into metal3-io:main Jun 10, 2024
5 checks passed
@metal3-io-bot
Copy link
Collaborator

@tuminoid: Updated the config configmap in namespace prow at cluster default using the following files:

  • key config.yaml using file prow/manifests/overlays/metal3/config.yaml

In response to this:

Bump Go image to 1.22 for ironic-standalone-operator tests, as we're bumping Go to 1.22 there.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tuminoid tuminoid deleted the tuomo/bump-go-for-ironic-operator branch June 10, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kashifest kashifest kashifest left review comments

@smoshiur1237 smoshiur1237 smoshiur1237 left review comments

@dtantsur dtantsur dtantsur approved these changes

@adilGhaffarDev adilGhaffarDev Awaiting requested review from adilGhaffarDev

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tuminoid @metal3-io-bot @dtantsur @kashifest @smoshiur1237