Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test new node image built with DIB #1384

Closed
wants to merge 1 commit into from

Conversation

NymanRobin
Copy link
Member

This PR is mainly meant to test the new image built with Disk Image builder in this PR:
#679

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign smoshiur1237 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 18, 2024
@Sunnatillo
Copy link
Member

/test-centos-integration-release-1-6
/test-ubuntu-e2e-integration-main

@NymanRobin
Copy link
Member Author

Thanks @Sunnatillo for running the tests, but seems like I missed this comment
# Kubectl version (do not forget to update KUBECTL_SHA256 when changing KUBERNETES_VERSION!)

But maybe just hard coding the image directly would work, but I will check this in a bit more detail if you do not already know?

@Sunnatillo
Copy link
Member

Lets run this on project infra and manually set all the vars there.

Bump golang to v1.21.9 and kind to 0.22.0
@metal3-io-bot metal3-io-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 19, 2024
@NymanRobin
Copy link
Member Author

/test-centos-integration-release-1-6
/test-ubuntu-e2e-integration-main

@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Apr 29, 2024
@metal3-io-bot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@NymanRobin
Copy link
Member Author

This can be closed as the changes are done already in #1389

@NymanRobin NymanRobin closed this Apr 29, 2024
@NymanRobin NymanRobin deleted the upgrade-node-image branch April 29, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants