Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump k8s to v1.30.0 #1389

Merged
merged 1 commit into from
Apr 29, 2024
Merged

bump k8s to v1.30.0 #1389

merged 1 commit into from
Apr 29, 2024

Conversation

kashifest
Copy link
Member

also bumps kind node image

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 24, 2024
@kashifest
Copy link
Member Author

/test metal3-ubuntu-e2e-integration-test-main
/test metal3-centos-e2e-integration-test-main
/test-centos-integration-release-1-6

@kashifest kashifest mentioned this pull request Apr 24, 2024
Merged
smoshiur1237
smoshiur1237 approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2024
Sunnatillo
Sunnatillo reviewed Apr 24, 2024
View reviewed changes
Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2024
tuminoid
tuminoid reviewed Apr 24, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tuminoid
Copy link
Member

Tide hello....
/retitle bump k8s to v1.30.0

@metal3-io-bot metal3-io-bot changed the title Bump k8s to v1.30.0 bump k8s to v1.30.0 Apr 24, 2024
@tuminoid
Copy link
Member

/test shellcheck
Wakey wakey

@kashifest
Copy link
Member Author

/retest

@tuminoid
Copy link
Member

/hold

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2024
@tuminoid
Copy link
Member

/test metal3-centos-e2e-integration-test-release-1-6
/unhold
Prow and GH branch protection mismatched.

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2024
@tuminoid
Copy link
Member

/hold

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2024
@kashifest
Copy link
Member Author

/hold cancel

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2024
@kashifest
Copy link
Member Author

/test-centos-integration-release-1-7

@tuminoid
Copy link
Member

/test-centos-integration-release-1-7

This probably won't work or tests wrong stuff, since #1381 is not merged.

@kashifest
Copy link
Member Author

/test-centos-integration-release-1-7

This probably won't work or tests wrong stuff, since #1381 is not merged.

Its testing main actually, as discussed offline we should fail here instead of testing main, I will try to push a fix later today.

@tuminoid
Copy link
Member

/hold
Its testing wrong stuff.

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2024
@tuminoid
Copy link
Member

1381 is merged, rebase.

@kashifest
Bump k8s to v1.30.0
f7c2c40 
Signed-off-by: Kashif Khan <kashif.khan@est.tech>
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2024
@kashifest
Copy link
Member Author

/test metal3-centos-e2e-integration-test-release-1-6
/test metal3-ubuntu-e2e-integration-test-main
/test-centos-integration-release-1-6
/test-centos-integration-release-1-7

@tuminoid
Copy link
Member

/test-centos-integration-release-1-6

@tuminoid
Copy link
Member

/test metal3-centos-e2e-integration-test-release-1-7
to get it configured

@kashifest
Copy link
Member Author

/hold cancel

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 29, 2024
smoshiur1237
smoshiur1237 approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smoshiur1237

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sunnatillo
Sunnatillo reviewed Apr 29, 2024
View reviewed changes
Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2024
@metal3-io-bot metal3-io-bot merged commit 3656f4b into metal3-io:main Apr 29, 2024
9 checks passed
@metal3-io-bot metal3-io-bot deleted the bump/k8s-v1.30 branch April 29, 2024 06:52
@NymanRobin NymanRobin mentioned this pull request Apr 29, 2024
Closed
@adilGhaffarDev adilGhaffarDev mentioned this pull request Aug 13, 2024
Closed
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sunnatillo Sunnatillo Sunnatillo left review comments

@tuminoid tuminoid tuminoid left review comments

@smoshiur1237 smoshiur1237 smoshiur1237 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kashifest @tuminoid @metal3-io-bot @Sunnatillo @smoshiur1237