WIP: Implement schema validation in Collector #232
Conversation
Bespaliy
changed the title
| this.keys = keys; | ||
| if (exact === false) this.exact = false; | ||
| if (typeof timeout === 'number') this.#timeout(timeout); | ||
| if (schema) this.schema = schema; |
There was a problem hiding this comment.
| if (schema) this.schema = schema; | |
| this.schema = schema; |
| if (!this.schema) return { valid: true, errors: [] }; | ||
|
|
||
| return this.schema.check(data); |
There was a problem hiding this comment.
| if (!this.schema) return { valid: true, errors: [] }; | |
| return this.schema.check(data); | |
| if (!this.schema) return { valid: true, errors: [] }; | |
| return this.schema.check(data); |
| @@ -48,6 +48,7 @@ | |||
| "eslint-config-prettier": "^9.1.0", | |||
| "eslint-plugin-import": "^2.29.0", | |||
| "eslint-plugin-prettier": "^5.0.0", | |||
| "metaschema": "^2.1.5", | |||
There was a problem hiding this comment.
| "metaschema": "^2.1.5", |
There was a problem hiding this comment.
Can we include a type schema in the 'd.ts' file, something like this:
interface ValidationResult {
valid: boolean;
errors: string[];
}
export class Schema {
check(value: any): ValidationResult;
}
or is there another approach?
There was a problem hiding this comment.
For testing purposes, we can create a mock Schema class that imitates the functionality of the 'check' method based on the test requirements.
| profile2.set('age', 'string'); | ||
|
|
||
| const expectedResult2 = new Error( | ||
| 'Invalid keys type: Field "id" not of expected type: number; Field "profile.firstname" not of expected type: string; Field "profile.age" not of expected type: number', |
| ); | ||
|
|
||
| try { | ||
| await ac1; |
There was a problem hiding this comment.
In all tests where you should catch an error, you should also throw an extra error if that test passed without the expected error. Otherwise, you simply won't notice that the test went wrong(after npm run test you will see simply one test less, that is, all test will go successfully without errors). It was recently added in all our tests.
So after all await in try you should add this line:
test.error(new Error('Should not be executed'));
| ); | ||
|
|
||
| try { | ||
| await ac1; |
There was a problem hiding this comment.
| await ac1; | |
| await ac1; | |
| test.error(new Error('Should not be executed')); |
| 'Invalid keys type: Field "fullName" is not expected', | ||
| ); | ||
| try { | ||
| await ac2; |
There was a problem hiding this comment.
| await ac2; | |
| await ac2; | |
| test.error(new Error('Should not be executed')); |
| ); | ||
|
|
||
| try { | ||
| await ac2; |
There was a problem hiding this comment.
| await ac2; | |
| await ac2; | |
| test.error(new Error('Should not be executed')); |
|
I believe that Collector should not know about schemas, it may depend on abstract interface (function validate). @Bespaliy |
tshemsedinov
changed the title
|
Closed in favour of #248 |
npm t)npm run fmt)