Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate collected data #248

Merged
merged 7 commits into from
Feb 12, 2024
Merged

Validate collected data #248

merged 7 commits into from
Feb 12, 2024

Conversation

timursevimli
Copy link
Member

#230

  • tests and linter show no problems (npm t)
  • tests are added/updated for bug fixes and new features
  • code is properly formatted (npm run fmt)
  • description of changes is added in CHANGELOG.md
  • update .d.ts typings

Copy link
Member

@tshemsedinov tshemsedinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few fixes

lib/collector.js Outdated Show resolved Hide resolved
lib/collector.js Outdated Show resolved Hide resolved
lib/collector.js Outdated Show resolved Hide resolved
lib/collector.js Outdated Show resolved Hide resolved
lib/collector.js Outdated Show resolved Hide resolved
lib/collector.js Outdated Show resolved Hide resolved
lib/collector.js Outdated Show resolved Hide resolved
@tshemsedinov tshemsedinov merged commit 99ce72d into metarhia:master Feb 12, 2024
10 checks passed
@tshemsedinov tshemsedinov changed the title Feature validate collected data Validate collected data Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants